Skip to content

Fix default help text for union of submodels. #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 8, 2024
Merged

Fix default help text for union of submodels. #472

merged 8 commits into from
Nov 8, 2024

Conversation

@kschwab
Copy link
Contributor

@kschwab kschwab commented Nov 7, 2024

Fixes #471.

@kschwab kschwab marked this pull request as draft November 7, 2024 14:20
@kschwab kschwab marked this pull request as ready for review November 7, 2024 15:31
@kschwab kschwab mentioned this pull request Nov 7, 2024
Closed
@hramezani
Copy link
Member

hramezani commented Nov 8, 2024

Thanks @kschwab

@hramezani hramezani merged commit 11a817c into pydantic:main Nov 8, 2024
21 checks passed
@kschwab kschwab deleted the cli-submodel-union-default-fix branch November 27, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hramezani hramezani hramezani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pydantic-settings fails to handle unions with defaults; raises Attribute error

2 participants

@kschwab @hramezani